fix: set a 1s default PeriodSeconds for the startupProbe#992
Open
NiccoloFei wants to merge 1 commit into
Open
Conversation
dosubot
Bot
added
size:XS
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
NiccoloFei
force-pushed
the
dev/startup-probe-period
branch
from
3e68e2f to
5aef349
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #991
Note: previously, with a 10s PeriodSeconds we had a maximum time
window of (
failureThreshold: 10,periodSeconds: 10=100s) to allowthe startup probe to succeed before the kubelet would kill the container.
With 1s PeriodSeconds that window is reduced to 10s. Should we also increase
the value of
failureThresholdaccordingly? I wouldn't restore the old time windowbut a value of 20 or 30 sounds reasonable.