Open
Conversation
Changes to the config, or to Nova behavior, may cause the driver elemnt in the libvirt xml config to change. VMs created before the config or behavior change, can then no longer be live-migrated. By always copying the driver element, compatibility between source and target XML is increased and live-migration issues are avoided. (cherry picked from commit 029f6dd) (cherry picked from commit 6ad8336)
Add a configuration option to enable SSH compression for copying ephemeral disks to remote hosts. This replaces the static list NO_COMPRESSION_TYPES. On fast local networks compression actually reduces the copy bandwith because of the CPU overhead. Implements: blueprint configurable-no-compression-image-types Change-Id: Ia935b45c56f81d5922608e37d5f263e5dd2e8a6f (cherry picked from commit 2a49c17dd526505f1b145d875542910778c88e02) (cherry picked from commit 9ddd567) (cherry picked from commit 8b00e7d)
Block device mappings for ephemeral and swap disks are not resized during instance resize operations. This causes virt drivers to not resize them. This patch resizes bdms for ephemeral and swap disks during finish_resize if: - All space allowed by the old flavor is used. - There is a single ephemeral disk or no ephemeral disk. - Swap is reduced in all cases if the new flavor allows less swap than currently allocated. For all other cases, the disk configuration is not touched as it's unclear how to resize. Note: Resizing to a flavor with less ephemeral disk space is not allowed and already prohibited in the API layer. TODO from old change: Virt driver related changes: - libvirt: a new imagebackend method _get_original_template_name is added, which aim is to get template name of an existing disk, which differs from specified one from driver's _create_image method in the case of resizing. Really, if we resize an ephemeral disk from 10 GB to 20 GB, the bdm object is already has 20 GB size, and _create_image specifies template name for 20 GB disk, but existing disk is created from 10 GB template and must continue to work with it. There is no reason to charge driver with such details, so that the new virtual method of imagebackend is the best choice. Resize ephemerals down details by drivers: - hyperv prevents resizing down in finish_migration method (except resizing to zero, in which case it removes ephemeral disk). This method raises an exception, and the instance is goes to error state. Unfortunately the same occures with revert of resize up operation when ephemeral bdm size is decreasing. I.e. it looks like this patch brings a problem there; - vmwareapi does not honor ephemeral bdms at all, but works with flavor ephemeral size directly. Moreover it recreates ephemeral disks on any resize operation. So that it probably does need to do something additionally with this patch; - ironic does not seem to has resizing supported at all. Conclusions: if vmwareapi behavior (recreating of ephemerals) is legal, fix hyperv only; if not - an early performed common check preventing resizing down whould be suitable. TODOes: - fix handling of resized bdms in hyperv; - check against lvm and ploop image backends; - fix a bug with disk.info inconsistency for flat backend after resizing (disks becomes qcow2 while disk.info still has 'raw' for them); Change-Id: Ie42a0b2f0019202c6cb1a1533a838a8549c000c8 Related-Bug: 1558880 Related-Bug: 1605720 (cherry picked from commit dcabe35) (cherry picked from commit 86662d5)
The custom autospec implementation in oslotest breaks mocking of bound instance methods. All tests pass without this custom implementation and no other OpenStack project uses this code. Change-Id: I0e9cf3bb6b0d622f29550aef29433cfbf76c259c (cherry picked from commit 5667e05)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.