[Bugfix #1279] Docs: carry post-merge thread addendum and porch completion state to main - #1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs-only follow-up to PR #1283 (the template-delivery fix for #1279), which merged as
54118ef0. Carries two post-merge artifacts tomainthat the merge itself couldn't include, following the[AIR #1239] Carry post-merge thread addendum to mainprecedent.No code, no tests, no framework files. 43 lines across 2 files.
What's here
1.
codev/state/bugfix-1279_thread.md— the closeout section (+41 lines)I wrote the thread's final section after PR #1283 merged, so it landed on the builder branch instead of
main. The version currently onmainstops at the CMAP section, missing:54118ef0, issue auto-closed) and the post-merge verification done againstmainitself rather than inferred from a green PRprgate is not sufficient to merge in this repo:mainindependently requires 1 approving review (which a builder cannot self-supply) plus 6 status checks, sogh pr merge --mergefails with "the base branch policy prohibits the merge" until both clear. This is the part most worth having onmain— the next builder will hit it.send-integration.e2e.test.ts("Hook timed out in 10000ms", Tower Integration Tests) failed twice on the branch and was called pre-existing flake on evidence; the final run passing that job in 1m23s on the same content confirmed it. Recording both the call and the confirmation, so the next person who sees this test fail has the history.2.
codev/projects/bugfix-1279-.../status.yaml(+2/−2)Porch's own completion write:
phase: pr → verifiedand a timestamp bump, emitted byporch doneafter the merge. Per the repo's data-capture convention, project state is committed tomain.Test Plan
Not applicable — no executable content changes. The framework files, protocol definitions, and test suite are untouched by this PR; all of that shipped in #1283 and is already on
main(verified there: includes present atspir/prompts/specify.md:95,spir/prompts/review.md:62,maintain/protocol.md:190;codev-skeleton/protocols/aspir/templates/absent).Note for the reviewer
Opened from the same
builder/bugfix-1279branch rather than a fresh docs branch, deliberately: the branch already contains exactly these two commits and nothing else beyondmain, and cutting a new branch would have meant moving the worktree's HEAD while the architect is holding the worktree pending a cleanup decision.I am not merging this myself — it will hit the same branch protection as #1283, and merge authorization is the architect's to obtain.
Related to #1279 (already closed by #1283). Intentionally no
Fixeskeyword.