Skip to content

fix(pool): warn when archive is enabled with checkpoint TTL off #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CMGS merged 1 commit into from
Jul 9, 2026
Merged

fix(pool): warn when archive is enabled with checkpoint TTL off #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sandboxd/pool/pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,9 @@ func NewManager(ctx context.Context, cfg *config.Config, eng Engine) (*Manager,
m.archiveEnabled = true
}
}
if m.archiveEnabled && m.ckptTTL == 0 {
log.WithFunc("pool.NewManager").Warn(ctx, "archive enabled with checkpoint_ttl_hours=0: a checkpoint whose delete fails is not reclaimed")
}
return m, nil
}

Expand Down
Loading