Bump @grpc/grpc-js from 1.14.1 to 1.14.4#4993
Conversation
Bumps [@grpc/grpc-js](https://github.com/grpc/grpc-node) from 1.14.1 to 1.14.4. - [Release notes](https://github.com/grpc/grpc-node/releases) - [Commits](https://github.com/grpc/grpc-node/compare/@grpc/grpc-js@1.14.1...@grpc/grpc-js@1.14.4) --- updated-dependencies: - dependency-name: "@grpc/grpc-js" dependency-version: 1.14.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This pull request aims to update @grpc/grpc-js from 1.14.1 to 1.14.4 to patch critical security vulnerabilities involving server crashes from malformed requests and compressed messages. It also addresses functional bugs related to server keep-alive timeouts and Envoy compatibility.
Codacy analysis reports that the PR is up to standards. However, the most critical finding is an implementation gap: the package.json file, which should contain the version update, is not present in the current diff. This prevents verification of the security fix implementation.
About this PR
- The package.json file is missing from the diff. Since the primary purpose of this PR is to update a dependency version, the modification to package.json must be included to verify the fix and ensure the security vulnerabilities (GHSA-5375-pq7m-f5r2, GHSA-99f4-grh7-6pcq) are correctly addressed.
Test suggestions
- Verify that the package.json file is updated to specify @grpc/grpc-js version 1.14.4.
- Perform integration testing on existing gRPC services to ensure no regressions in communication or connectivity.
- Verify the gRPC server remains stable when receiving malformed requests or compressed data (regression testing for the security fixes).
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the package.json file is updated to specify @grpc/grpc-js version 1.14.4.
2. Perform integration testing on existing gRPC services to ensure no regressions in communication or connectivity.
3. Verify the gRPC server remains stable when receiving malformed requests or compressed data (regression testing for the security fixes).
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Bumps @grpc/grpc-js from 1.14.1 to 1.14.4.
Release notes
Sourced from @grpc/grpc-js's releases.
Commits
a380735Merge pull request #3052 from murgatroid99/grpc-js_1.14.45b8d37bMerge commit from fork6a97456Merge commit from forke5e0b1dgrpc-js: Bump version to 1.14.45029a26Make compression error a static string2fe55fdFix crashes when receiving malformed compressed data234f917Fix server crash when handling invalid requestsacef8d4Merge pull request #3043 from murgatroid99/rbac_types_change_fix_1.144f3c58fgrpc-js-xds: Update RBAC code to handle Node type change, pin@types/nodeccd29b2Merge pull request #3032 from murgatroid99/grpc-js_retry_half_close_1.14Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.