Bump ws, @backstage/cli and @nx/next#4996
Conversation
Bumps [ws](https://github.com/websockets/ws) to 6.2.6 and updates ancestor dependencies [ws](https://github.com/websockets/ws), [@backstage/cli](https://github.com/backstage/backstage/tree/HEAD/packages/cli) and [@nx/next](https://github.com/nrwl/nx/tree/HEAD/packages/next). These dependencies need to be updated together. Updates `ws` from 6.2.3 to 6.2.6 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@6.2.3...6.2.6) Updates `ws` from 7.5.10 to 7.5.13 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@6.2.3...6.2.6) Updates `ws` from 8.18.0 to 8.21.1 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@6.2.3...6.2.6) Updates `@backstage/cli` from 0.34.4 to 0.36.4 - [Release notes](https://github.com/backstage/backstage/releases) - [Changelog](https://github.com/backstage/backstage/blob/master/packages/cli/CHANGELOG.md) - [Commits](https://github.com/backstage/backstage/commits/HEAD/packages/cli) Updates `@nx/next` from 19.5.7 to 23.1.0 - [Release notes](https://github.com/nrwl/nx/releases) - [Commits](https://github.com/nrwl/nx/commits/23.1.0/packages/next) --- updated-dependencies: - dependency-name: ws dependency-version: 6.2.6 dependency-type: indirect - dependency-name: ws dependency-version: 7.5.13 dependency-type: indirect - dependency-name: ws dependency-version: 8.21.1 dependency-type: direct:production - dependency-name: "@backstage/cli" dependency-version: 0.36.4 dependency-type: direct:production - dependency-name: "@nx/next" dependency-version: 23.1.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
Manual review has identified a high-risk dependency mismatch that automated tools did not flag. While the workspace is currently reported as up to standards, updating the @nx/next plugin across multiple major versions without a corresponding synchronization of other @nx packages and without running migration scripts will likely lead to broken builds and configuration conflicts. Major integration and functionality tests for the websocket and workspace updates are currently missing from the PR.
About this PR
- Major upgrades for workspace plugins typically require migration scripts to update internal configuration files and project structures. The absence of these changes suggests a significant risk of configuration rot or broken builds.
Test suggestions
- Verify project build and integration tests pass following the major version jump of @nx/next.\n- [ ] Verify that websockets functionality is unaffected by the library updates.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify project build and integration tests pass following the major version jump of @nx/next.\n- [ ] Verify that websockets functionality is unaffected by the library updates.
Low confidence findings
- The PR description indicates updates for multiple major versions of the websocket library, but the changes only reflect an update for a single version line. Verify if transitive dependencies or other direct dependencies were intended to be included.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| "@nx/linter": "^19.4.2", | ||
| "@nx/nest": "^19.0.4", | ||
| "@nx/next": "^19.5.2", | ||
| "@nx/next": "^23.1.0", |
There was a problem hiding this comment.
🔴 HIGH RISK
Updating a workspace plugin to a new major version while keeping other related packages on a previous major version will likely cause build failures and dependency conflicts. All related workspace packages must be kept in sync. Use the workspace migration tool to upgrade the entire workspace consistently.
Bumps ws to 6.2.6 and updates ancestor dependencies ws, @backstage/cli and @nx/next. These dependencies need to be updated together.
Updates
wsfrom 6.2.3 to 6.2.6Release notes
Sourced from ws's releases.
Commits
dd3ae14[dist] 6.2.6899bf9e[fix] Reset the fragment counter when the message is complete1a0afaf[dist] 6.2.54f19c0c[fix] Lower default values ofmaxBufferedChunksandmaxFragments58ddc8c[fix] Count empty fragments toward the limit (#2329)86d3e8a[dist] 6.2.4a76e211[security] Limit retained message partsUpdates
wsfrom 7.5.10 to 7.5.13Release notes
Sourced from ws's releases.
Commits
dd3ae14[dist] 6.2.6899bf9e[fix] Reset the fragment counter when the message is complete1a0afaf[dist] 6.2.54f19c0c[fix] Lower default values ofmaxBufferedChunksandmaxFragments58ddc8c[fix] Count empty fragments toward the limit (#2329)86d3e8a[dist] 6.2.4a76e211[security] Limit retained message partsUpdates
wsfrom 8.18.0 to 8.21.1Release notes
Sourced from ws's releases.
Commits
dd3ae14[dist] 6.2.6899bf9e[fix] Reset the fragment counter when the message is complete1a0afaf[dist] 6.2.54f19c0c[fix] Lower default values ofmaxBufferedChunksandmaxFragments58ddc8c[fix] Count empty fragments toward the limit (#2329)86d3e8a[dist] 6.2.4a76e211[security] Limit retained message partsUpdates
@backstage/clifrom 0.34.4 to 0.36.4Changelog
Sourced from @backstage/cli's changelog.
... (truncated)
Commits
Updates
@nx/nextfrom 19.5.7 to 23.1.0Release notes
Sourced from @nx/next's releases.
... (truncated)
Commits
a88e494chore(repo): migrate to nx 23.1.0-rc.2 (#36269)f45a6a1fix(testing): disable justInTimeCompile for webpack Cypress component testing...df5157bfeat(core): support filtered targetDefaults via the nested-array shape (#36049)f22e75cfeat(repo): enable the tsgo compiler workspace-wide (#35926)192f668feat(angular): support angular v22 (#35851)b09b702feat(misc): add next 14 to 15 and react 18 to 19 upgrade paths (#36031)a44086efeat(linter)!: drop eslint v8 support (#36006)71bbc70feat(core): revert array-shape targetDefaults support pending redesign and re...aa9ce7afix(misc): rename createNodesV2 value usages in v23 migration, not just impor...6598a0bchore(core): rename supportsOptionalUpdates to supportsOptionalMigrations (#3...Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for
@nx/nextsince your current version.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.