Bump bn.js - #5008
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps and [bn.js](https://github.com/indutny/bn.js). These dependencies needed to be updated together. Updates `bn.js` from 5.2.1 to 5.2.5 - [Release notes](https://github.com/indutny/bn.js/releases) - [Changelog](https://github.com/indutny/bn.js/blob/master/CHANGELOG.md) - [Commits](indutny/bn.js@v5.2.1...v5.2.5) Updates `bn.js` from 4.12.0 to 4.12.5 - [Release notes](https://github.com/indutny/bn.js/releases) - [Changelog](https://github.com/indutny/bn.js/blob/master/CHANGELOG.md) - [Commits](indutny/bn.js@v5.2.1...v5.2.5) --- updated-dependencies: - dependency-name: bn.js dependency-version: 5.2.5 dependency-type: indirect - dependency-name: bn.js dependency-version: 4.12.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
The pull request is currently in an incomplete state as the diff contains no file modifications, meaning the intended dependency updates have not been implemented. Furthermore, the specific bug fixes associated with this update are not verified by any new test cases. The PR description is also malformed and requires correction before this can be considered for merging.
About this PR
- The PR contains no file changes. The dependency updates have not been applied to package.json or the lockfiles in the current commit.
- The PR description is malformed and contains incomplete sentences, suggesting a failure in automated generation or missing manual input.
Test suggestions
- Verify
divRoundcorrectly handles rounding for negative operands. - Verify
imulnandmulncorrectly normalize the sign when multiplying by zero. - Verify
inotncorrectly masks surplus words to maintain the specified width.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify `divRound` correctly handles rounding for negative operands.
2. Verify `imuln` and `muln` correctly normalize the sign when multiplying by zero.
3. Verify `inotn` correctly masks surplus words to maintain the specified width.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps and bn.js. These dependencies needed to be updated together.
Updates
bn.jsfrom 5.2.1 to 5.2.5Changelog
Sourced from bn.js's changelog.
Commits
eb2e57c5.2.573fb9a4fix: correct divRound rounding for negative operands (#320)dd84df8fix: normalize sign when imuln multiplies by zero (#321)96f2f815.2.4dc3429ffix: clear surplus words in inotn so notn(width) stays below 2 ** width (#319)ea6c0725.2.333df26bfix imaskn state (#317)6db7c385.2.2c7e1a53Fix imuln/muln with zero (#313)4cc0bfadocs: mention the max plain JS number argument value (#307)Updates
bn.jsfrom 4.12.0 to 4.12.5Changelog
Sourced from bn.js's changelog.
Commits
eb2e57c5.2.573fb9a4fix: correct divRound rounding for negative operands (#320)dd84df8fix: normalize sign when imuln multiplies by zero (#321)96f2f815.2.4dc3429ffix: clear surplus words in inotn so notn(width) stays below 2 ** width (#319)ea6c0725.2.333df26bfix imaskn state (#317)6db7c385.2.2c7e1a53Fix imuln/muln with zero (#313)4cc0bfadocs: mention the max plain JS number argument value (#307)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.