Bump underscore and @backstage/cli - #5009
Conversation
Removes [underscore](https://github.com/jashkenas/underscore). It's no longer used after updating ancestor dependency [@backstage/cli](https://github.com/backstage/backstage/tree/HEAD/packages/cli). These dependencies need to be updated together. Removes `underscore` Updates `@backstage/cli` from 0.34.4 to 0.36.4 - [Release notes](https://github.com/backstage/backstage/releases) - [Changelog](https://github.com/backstage/backstage/blob/master/packages/cli/CHANGELOG.md) - [Commits](https://github.com/backstage/backstage/commits/HEAD/packages/cli) --- updated-dependencies: - dependency-name: underscore dependency-version: dependency-type: indirect - dependency-name: "@backstage/cli" dependency-version: 0.36.4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
The PR implementation is currently incomplete. Although the '@backstage/cli' version bump has been applied, the modifications to the 'underscore' dependency mentioned in both the title and description are entirely missing from the package.json diff. This discrepancy between the stated intent and the code changes must be resolved before merging.
About this PR
- There is a discrepancy between the PR title, which mentions 'bumping' underscore, and the description, which mentions 'removing' it. Neither action is reflected in the current code changes.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| "@babel/register": "^7.23.7", | ||
| "@babel/runtime": "^7.25.0", | ||
| "@backstage/cli": "^0.34.4", | ||
| "@backstage/cli": "^0.36.4", |
There was a problem hiding this comment.
🟡 MEDIUM RISK
The changes to the 'underscore' dependency mentioned in the PR title and description are missing from the package.json diff. Please ensure the dependency is updated or removed as intended.
Removes underscore. It's no longer used after updating ancestor dependency @backstage/cli. These dependencies need to be updated together.
Removes
underscoreUpdates
@backstage/clifrom 0.34.4 to 0.36.4Changelog
Sourced from @backstage/cli's changelog.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.