Bump @octokit/plugin-paginate-rest and @backstage/cli - #5011
Open
dependabot[bot] wants to merge 1 commit into
Open
Bump @octokit/plugin-paginate-rest and @backstage/cli#5011dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Removes [@octokit/plugin-paginate-rest](https://github.com/octokit/plugin-paginate-rest.js). It's no longer used after updating ancestor dependency [@backstage/cli](https://github.com/backstage/backstage/tree/HEAD/packages/cli). These dependencies need to be updated together. Removes `@octokit/plugin-paginate-rest` Updates `@backstage/cli` from 0.34.4 to 0.36.4 - [Release notes](https://github.com/backstage/backstage/releases) - [Changelog](https://github.com/backstage/backstage/blob/master/packages/cli/CHANGELOG.md) - [Commits](https://github.com/backstage/backstage/commits/HEAD/packages/cli) --- updated-dependencies: - dependency-name: "@octokit/plugin-paginate-rest" dependency-version: dependency-type: indirect - dependency-name: "@backstage/cli" dependency-version: 0.36.4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
The implementation is incomplete as it does not include the removal of @octokit/plugin-paginate-rest, which is explicitly stated as a goal in the PR title and description. While the @backstage/cli update is correctly implemented and the code meets general quality standards, this discrepancy between the intended and actual changes should prevent merging until the cleanup is performed.
About this PR
- Implementation discrepancy: The removal of @octokit/plugin-paginate-rest is missing from the diff, although it is highlighted as a primary objective in the PR title. Please ensure the dependency is removed to align with the stated intent.
Test suggestions
- Verify that @backstage/cli is updated and that the application builds and runs correctly.
- Verify that @octokit/plugin-paginate-rest is removed from package.json.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that @backstage/cli is updated and that the application builds and runs correctly.
2. Verify that @octokit/plugin-paginate-rest is removed from package.json.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes @octokit/plugin-paginate-rest. It's no longer used after updating ancestor dependency @backstage/cli. These dependencies need to be updated together.
Removes
@octokit/plugin-paginate-restUpdates
@backstage/clifrom 0.34.4 to 0.36.4Changelog
Sourced from @backstage/cli's changelog.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.