Bump glob from 10.4.5 to 12.0.0#5014
Conversation
Bumps [glob](https://github.com/isaacs/node-glob) from 10.4.5 to 12.0.0. - [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md) - [Commits](isaacs/node-glob@v10.4.5...v12.0.0) --- updated-dependencies: - dependency-name: glob dependency-version: 12.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the glob dependency to version 12.0.0. While Codacy reporting shows no new static analysis issues, this major version jump introduces a significant breaking change: support for Node.js versions earlier than v20 has been dropped as of version 11.0.0.
The current PR lacks verification that the project's runtime and CI/CD environments are compatible with this requirement. Without updating the environment or the project's configuration (e.g., the engines field), this change may lead to immediate failures during the build or at runtime.
About this PR
- Major version upgrades in this library (v11 and v12) include breaking changes, such as the removal of specific CLI options like
--shell. Ensure that any internal scripts or tools relying on the CLI functionality of this package are audited for compatibility.
Test suggestions
- Verify that all features utilizing 'glob' for file pattern matching continue to function correctly after the major version upgrade.
- Verify that the CI/CD environment and runtime are using Node.js v20 or later, as 'glob' v11+ dropped support for older versions.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that all features utilizing 'glob' for file pattern matching continue to function correctly after the major version upgrade.
2. Verify that the CI/CD environment and runtime are using Node.js v20 or later, as 'glob' v11+ dropped support for older versions.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| "eslint-plugin-you-dont-need-lodash-underscore": "^6.14.0", | ||
| "extract-css-chunks-webpack-plugin": "^4.10.0", | ||
| "glob": "^10.3.15", | ||
| "glob": "^12.0.0", |
There was a problem hiding this comment.
🟡 MEDIUM RISK
Updating to glob v12.0.0 requires Node.js v20 or higher. Please ensure the project's engines field and CI environment are updated to reflect this requirement.
Bumps glob from 10.4.5 to 12.0.0.
Changelog
Sourced from glob's changelog.
... (truncated)
Commits
2b03cca12.0.0d56203dprettier configbb521e5Remove --shell option where unsafe to use2551fb511.1.047473c0bin: Do not expose filenames to shell expansionbc33fe1skip tilde test on systems that lack tilde expansion59bf9cafix notesdde4fa6docs(README): add #anchor and improvenotes0559b0edocs: add better links to path-scurry docsc9773c2fix: correct typos inREADME.mdMaintainer changes
This version was pushed to npm by isaacs, a new releaser for glob since your current version.
Install script changes
This version adds
preparescript that runs during installation. Review the package contents before updating.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.