fix rubocop - #1002
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates various dependencies, upgrades the Ruby base image, adds documentation for several RuboCop cops, and updates the RuboCop runner configuration. Feedback on these changes highlights three key issues: the specified Ruby base image in the Dockerfile does not exist and will cause build failures, the newly added rubocop-shopify plugin is missing from the Scala runner's plugin list, and unstable pre-release dependency versions have been introduced in build.sbt.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
This PR performs a significant update to the RuboCop engine, upgrading the base Ruby image to 4.0.6 and modernizing key Scala dependencies (Jackson 3.2.1, Play-JSON 3.1.0-M10). It also shifts the configuration generation from 'require' to the newer 'plugins' format and adds documentation for the Lint/NoReturnInMemoization cop. While the static analysis is clean, the lack of a PR description for such major upgrades is a concern, and the implementation of the new configuration logic needs verification.
About this PR
- The PR description is empty. Given the major version upgrades (Ruby 4.0, Jackson 3.x), please provide context on the motivation and any potential breaking changes or compatibility considerations addressed during this upgrade.
Test suggestions
- Verify that the engine generates a RuboCop configuration file using the 'plugins:' key.
- Verify that the new 'Lint/NoReturnInMemoization' documentation is correctly mapped in description.json and patterns.json.
- Verify that the upgraded Jackson and Play-JSON libraries are compatible with the current Scala code.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the engine generates a RuboCop configuration file using the 'plugins:' key.
2. Verify that the new 'Lint/NoReturnInMemoization' documentation is correctly mapped in description.json and patterns.json.
3. Verify that the upgraded Jackson and Play-JSON libraries are compatible with the current Scala code.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
No description provided.