build(deps): bump loofah from 2.25.1 to 2.25.2 - #1003
Conversation
Bumps [loofah](https://github.com/flavorjones/loofah) from 2.25.1 to 2.25.2. - [Release notes](https://github.com/flavorjones/loofah/releases) - [Changelog](https://github.com/flavorjones/loofah/blob/main/CHANGELOG.md) - [Commits](flavorjones/loofah@v2.25.1...v2.25.2) --- updated-dependencies: - dependency-name: loofah dependency-version: 2.25.2 dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates loofah to address security vulnerabilities involving URI filter bypasses and SVG attribute handling. While the update is a positive security step, the PR lacks automated verification for the specific vulnerabilities being patched (e.g., semicolon-less character references and 'feed' protocol removal). Additionally, a known security risk remains in the rails-html-sanitizer dependency within the lockfile, which should be mitigated to ensure the application's sanitization logic is fully secure.
1 comment outside of the diff
Gemfile.lock
line 238🟡 MEDIUM RISK
The rails-html-sanitizer gem is vulnerable to XSS (GHSA-cj75-f6xr-r4g7). Resolution is required to mitigate this security risk.
Test suggestions
- Test sanitization of URIs using semicolon-less numeric character references to bypass protocol checks
- Test sanitization of URIs using or to split the protocol scheme
- Test that SVG href attributes are restricted to local references
- Test that data: URIs with malformed mediatypes or missing commas are handled correctly
- Test that the 'feed' URI scheme is no longer allowed
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Test sanitization of URIs using semicolon-less numeric character references to bypass protocol checks
2. Test sanitization of URIs using 	 or 
 to split the protocol scheme
3. Test that SVG href attributes are restricted to local references
4. Test that data: URIs with malformed mediatypes or missing commas are handled correctly
5. Test that the 'feed' URI scheme is no longer allowed
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Bumps loofah from 2.25.1 to 2.25.2.
Release notes
Sourced from loofah's releases.
Changelog
Sourced from loofah's changelog.
Commits
2706d7eversion bump to v2.25.21afde0cMerge pull request #308 from flavorjones/security-2252f1be9d8Updateallowed_uri?to decode semicolon-less numeric character references5e91af8Updateallowed_uri?to handle named whitespace character references20867b9Properly restrict SVG href attributes5f3bff4test: opt into JSON comment parsing for sanitizer testdata (#307)b07713dtest: do not run in verbose modebabe7a8doc: update CHANGELOGa8d8d96Merge pull request #305 from flavorjones/drop-protocol-typob52f4b0version bump to 2.25.2.beta1Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)