build(deps): bump rails-html-sanitizer from 1.7.0 to 1.7.1 - #1004
Open
dependabot[bot] wants to merge 1 commit into
Open
build(deps): bump rails-html-sanitizer from 1.7.0 to 1.7.1#1004dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [rails-html-sanitizer](https://github.com/rails/rails-html-sanitizer) from 1.7.0 to 1.7.1. - [Release notes](https://github.com/rails/rails-html-sanitizer/releases) - [Changelog](https://github.com/rails/rails-html-sanitizer/blob/main/CHANGELOG.md) - [Commits](rails/rails-html-sanitizer@v1.7.0...v1.7.1) --- updated-dependencies: - dependency-name: rails-html-sanitizer dependency-version: 1.7.1 dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This security-critical update addresses GHSA-cj75-f6xr-r4g7 by upgrading rails-html-sanitizer to 1.7.1. While the quality analysis indicates the PR is up to standards, the effectiveness of this patch depends on a transitive update to loofah (version 2.25.2 or higher). This verification is the primary concern for this review.
About this PR
- Ensure that Gemfile.lock reflects both the update of rails-html-sanitizer to 1.7.1 and the transitive update of loofah to version 2.25.2 or higher. This is necessary to satisfy the requirements of the GHSA-cj75-f6xr-r4g7 security fix.
Test suggestions
- Verify Gemfile.lock reflects the update of rails-html-sanitizer to 1.7.1
- Verify Gemfile.lock reflects the transitive update of loofah to version >= 2.25.2
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify Gemfile.lock reflects the update of rails-html-sanitizer to 1.7.1
2. Verify Gemfile.lock reflects the transitive update of loofah to version >= 2.25.2
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps rails-html-sanitizer from 1.7.0 to 1.7.1.
Release notes
Sourced from rails-html-sanitizer's releases.
Changelog
Sourced from rails-html-sanitizer's changelog.
Commits
4f37e3dversion bump to v1.7.1b4673b9Merge pull request #223 from rails/svg-href-local-ref74dcb80Properly restrict SVG href attributes11ee440Adjust data: URI mediatype tests for loofah 2.25.2 (#222)bc9622cHarden GitHub Actions workflows (#220)3459ffddep(dev): update nokogiri (#219)8aa4bb2build(deps-dev): bump concurrent-ruby from 1.3.6 to 1.3.7 (#218)4ddc0c7dep(dev): update development dependencies (#217)f87abb4Merge pull request #215 from yuri-zubov/reduce-gem-size527b317Reduce gem size by excluding test filesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)