fix(charts): constrain the value, not the pixel, in NumericScale.trac…#1311
Open
nebojsa-peric wants to merge 1 commit into
Open
fix(charts): constrain the value, not the pixel, in NumericScale.trac…#1311nebojsa-peric wants to merge 1 commit into
nebojsa-peric wants to merge 1 commit into
Conversation
…kValue `trackValue(v, offset, constrain)` clamped the raw pixel coordinate `v` instead of the computed `value` when `constrain` was true, mismatching TimeScale.trackValue. With a pixel range wider than the value range, an in-range value whose pixel fell outside [min, max] was wrongly clamped. - Extract the private NumericScale calculator into its own React-free module so it can be unit-tested in isolation (public API unchanged; it is not re-exported from the axis barrel). - Add a regression test covering constrained/unconstrained trackValue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…kValue
trackValue(v, offset, constrain)clamped the raw pixel coordinatevinstead of the computedvaluewhenconstrainwas true, mismatching TimeScale.trackValue. With a pixel range wider than the value range, an in-range value whose pixel fell outside [min, max] was wrongly clamped.According to claude this is a bug:
