fix: wrap fabricator time attributes in blocks to prevent flaky tests#2631
Merged
Conversation
The Fabrication gem evaluates attributes without blocks once and caches the value. When was first called inside a travel_to block (e.g. in event_spec.rb), the date_and_time default was cached as a past date. All subsequent events fabricated in the same process reused that cached value, making them appear as past events. This caused the view_event_spec feature tests to fail because the event page showed 'This event has already occurred' instead of the 'Log in' link. Also reset Capybara sessions after each feature spec as a defensive measure against session leaks between tests.
olleolleolle
approved these changes
Jun 6, 2026
Collaborator
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
Looks good, did you experience flakes when not having the reset_sessions!? Anyway, good fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Fabrication gem evaluates attributes without blocks once and caches the value. When
Fabricate(:event)was first called inside atravel_toblock (e.g. inevent_spec.rb), thedate_and_timedefault was cached as a past date. All subsequent events fabricated in the same process reused that cached value, making them appear as past events.This caused
view_event_specfeature tests to fail because the event page showed 'This event has already occurred' instead of the 'Log in' link.Changes
date_and_time,rsvp_opens_at, andpast_workshop.date_and_timein Fabrication blocks so they evaluate dynamically at fabrication timeVerification
Reproduced the failure locally with the exact CI command and seed (41835, group 2). After the fix, the same command passes with 0 failures. Ran multiple additional seeds and the full test suite — all green.