Skip to content

fix: TomSelect test helper flake — use JS value-set instead of send_keys #2752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mroderick merged 2 commits into from
Jul 28, 2026
+15 −9
Merged

fix: TomSelect test helper flake — use JS value-set instead of send_keys #2752

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f03625c
fix: use JS value-set for TomSelect helper instead of send_keys
mroderick Jul 28, 2026
84263e8
Merge branch 'master' into fix/tomselect-flake-2
mroderick Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions spec/support/select_from_tom_select.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,25 +15,31 @@ def select_from_tom_select(item_text, from:)
wrapper = select.find(:xpath, '..')
expect(wrapper).to have_css('.ts-control', wait: 15)

# Open dropdown and focus the input. The click on .ts-control opens the
# dropdown; a second click on the input focuses it, and the explicit JS
# focus call guards against headless CI drivers where Capybara's click alone
# does not reliably focus the field before keys are sent.
# Open the dropdown by clicking the control
wrapper.find('.ts-control').click
input = wrapper.find('.ts-control input')
input.click
page.execute_script('arguments[0].focus();', input.native)

# Type first 3 characters to trigger search (shouldLoad requires >= 3)
input.send_keys(item_text[0, 3])
# Type first 3 characters to trigger search (shouldLoad requires >= 3).
# Use JS to set the value and dispatch an input event directly, instead of
# send_keys (which can race with TomSelect's debounce timer in headless CI
# when multiple parallel processes contend for CPU).
page.execute_script(
"arguments[0].value = arguments[1]; arguments[0].dispatchEvent(new Event('input', { bubbles: true }));",
input.native, item_text[0, 3]
)

# Wait for the initial search results to load after the debounce and AJAX.
# Uses Capybara's adaptive wait instead of a blind sleep so slow CI environments
# get enough time while fast environments don't waste a fixed wait.
expect(wrapper).to have_css('.ts-dropdown .option', wait: 15)

# Type the rest if item_text is longer than 3 characters
input.send_keys(item_text[3..]) if item_text.length > 3
if item_text.length > 3
page.execute_script(
"arguments[0].value = arguments[1]; arguments[0].dispatchEvent(new Event('input', { bubbles: true }));",
input.native, item_text[3..]
)
end

# Wait for updated results after the refined search
expect(wrapper).to have_css('.ts-dropdown .option', text: item_text, wait: 10)
Expand Down