style(rubocop): resolve Lint/Debugger todo entry - #2772
Merged
Conversation
mroderick
marked this pull request as ready for review
July 31, 2026 19:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Lint/Debuggertodo entry excluded all ofspec/spec_helper.rbbecause the cop flagspage.save_screenshot— a false positive, since Capybara'ssave_screenshotmatches the cop's defaultDebuggerMethodspattern (save_screenshotis a pry-family method name).Solution
Drop the file-wide exclusion from
.rubocop_todo.ymland disable the cop inline around the single call site instead, so the rest ofspec_helper.rbgets linted again.Split out from #2768; independent of the other RuboCop PRs.