feat: Add Traefik option for ingress values.yaml; Add condition for t…#131
Merged
Conversation
…emplate render; Add CI Test;
igoralveslima
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds optional Traefik ingress controller support to the generic service Helm chart while maintaining full backward compatibility with the existing nginx-nlb ingress configuration.
Changes
templates/ingress.yaml- Added conditional rendering based oningress.class:spec.ingressClassNamefield for Traefik (vs annotation for nginx-nlb)PrefixpathType for Traefik (vsImplementationSpecificfor nginx-nlb)80for Traefik (vs named porthttpfor nginx-nlb)values.yaml- Added new configuration options:ingress.class:Choose ingress controller (nginx-nlbortraefik)ingress.traefik:Traefik-specific settings (annotations, ingressClassName)ci/traefik-ingress-values.yaml- Added CI test configurationUsage
Default (nginx-nlb) - unchanged:
Opt-in to Traefik:
Backward Compatibility
Testing