fix: prevent sentry-sdk TypeError with version check - #753
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeError: Span.__init__() got an unexpected keyword argument 'name'that occurred whencodecov-cliattempted to usesentry_sdk.start_span(name=...)with an older version ofsentry-sdk.The root cause was that while
pyproject.tomlspecifiedsentry-sdk==2.*, some environments could still resolve to ansentry-sdkversion older than 2.0.0, which does not support thenameargument inSpan.__init__().Changes include:
pyproject.toml: Thesentry-sdkdependency is now specified assentry-sdk>=2.0.0,<3.0.0to explicitly enforce a minimum version of 2.0.0.codecov_cli/opentelemetry.py, a check has been added to verify the installedsentry_sdkversion before initializing telemetry. If the version is older than 2.0.0, telemetry initialization is skipped, and a warning is logged, preventing theTypeErrorand ensuring graceful degradation.Fixes CLI-FZ