Fix: Disable Jest globalSetup/globalTeardown to avoid external dependencies

[mohammedahmed18]

Problem

Codeflash optimization runs were failing on projects using Jest with globalSetup or globalTeardown hooks that depend on external tools like Docker.

Affected projects: Budibase (and any Jest project with global hooks requiring unavailable dependencies)

Symptoms:

• Jest: Got error running globalSetup errors
• docker: not found blocking all test execution
• 100% optimization failure rate for affected functions

Example trace IDs:

• 0c5fcd53-a797-4268-8344-e730f40be867
• 76f8e8c6-e988-4db9-a02c-5fe0b065d773
• d5759d1d-3ac4-457a-a748-bf9edd15c6b0

Root Cause

Codeflash generates wrapper Jest configs that extend original configs using:

const originalConfig = require('./jest.config.js');
module.exports = { ...originalConfig, /* overrides */ };

This caused globalSetup and globalTeardown hooks to be inherited, triggering external dependencies.

Solution

Modified 3 config generation functions to explicitly disable global hooks:

1. _create_codeflash_jest_config - Main wrapper config

   • Now explicitly sets globalSetup: undefined and globalTeardown: undefined
   • Added TypeScript config handling (can't require .ts files from CommonJS)

2. _create_runtime_jest_config - Runtime config for external test directories

   • Also disables global hooks in both extend and standalone modes

3. _get_jest_config_for_project - Config resolver

   • Changed to ALWAYS create codeflash config (not just for bundler moduleResolution)
   • Ensures all Jest runs use configs with disabled global hooks

Testing

• ✅ Added 6 new unit tests covering all scenarios
• ✅ All 69 existing JavaScript tests pass
• ✅ Linting passes (uv run prek)
• ✅ Verified Docker/globalSetup errors eliminated in Budibase runs

Impact

Codeflash-generated tests are now self-contained and won't trigger project-level setup/teardown hooks. This makes optimization work on more real-world projects without environmental prerequisites.

Review Notes

The fix is conservative - it only affects Codeflash-generated Jest configs, not the project's original configs. User tests continue to use global hooks normally.

[claude]

Claude finished @mohammedahmed18's task in 5m 0s —— View job

---

PR Review Summary

• Triage PR size (LARGE: 67 lines of production code changed)
• Run lint/typecheck (fixed test file issues)
• Resolve stale review threads (none)
• Code review
• Duplicate detection
• Test coverage
• Fixes pushed

---

Prek Checks

Ruff format reports 1 file reformatted, but this appears to be a pre-existing file in the branch that differs from origin/main (not in the PR's 2 changed files). The PR-specific files pass ruff check and format.

Fixed and pushed: The new test file had several issues that I've corrected in commit cb9be293:

• tempfile.TemporaryDirectory() → tmp_path fixture (required by repo testing conventions in .claude/rules/testing.md)
• Removed unused imports (import tempfile, import pytest)
• Added -> None return type annotations (all 6 test functions were missing them, causing mypy errors)
• Added encoding="utf-8" to write_text/read_text calls

---

Code Review

Bug: Duplicate globalSetup: undefined entries in standalone config

In _create_codeflash_jest_config (test_runner.py:326–340), when no original config exists, the generated JS has globalSetup: undefined and globalTeardown: undefined declared in the standalone config block. Looking at the diff, these appear once (not twice), so this is fine — just worth confirming the generated output doesn't have duplicate keys.

Behavior change scope: _get_jest_config_for_project now always creates a codeflash config

Previously only ESM/bundler projects got a wrapper config; now ALL projects do. This is intentional per the PR description, but has a subtle risk: if _create_codeflash_jest_config is called for a TypeScript config project (.ts extension), it silently falls through to the standalone config branch, which means all original Jest settings (transforms, module name mappers, etc.) are dropped, not just the global hooks. The PR handles this by creating a minimal standalone config, but that may miss project-specific settings. This is an existing limitation worth documenting.

No tests for the monorepo root detection logic Fix this →

The monorepo root detection block is added to 3 functions but is not tested:

• run_jest_behavioral_tests (line 800)
• run_jest_benchmarking_tests (line 1071)
• run_jest_line_profile_tests (line 1255)

---

Duplicate Detection

HIGH confidence: Monorepo detection block duplicated 3× Fix this →

The same 10-line monorepo detection block appears identically in all three Jest runner functions (lines ~800, ~1071, ~1255). This should be extracted into a helper like _resolve_project_root(test_files, project_root). This is new in this PR — it was added copy-pasted to all three locations.

---

Test Coverage

The 6 new tests cover the core fix well (all config generation scenarios for globalSetup/globalTeardown). Coverage gap: no tests for the monorepo root detection logic added to the runner functions.

---

Last updated: 2026-04-06
| Branch