⚡️ Speed up method StringUtils.isBlank by 17%#2
Open
codeflash-ai[bot] wants to merge 1 commit intomainfrom
Open
⚡️ Speed up method StringUtils.isBlank by 17%#2codeflash-ai[bot] wants to merge 1 commit intomainfrom
StringUtils.isBlank by 17%#2codeflash-ai[bot] wants to merge 1 commit intomainfrom
Conversation
The optimization caches `string.length()` in a local variable and stores each `string.charAt(i)` result in a local `char` before passing it to `Character.isWhitespace`, eliminating repeated virtual method calls and bounds checks inside the hot loop. Line profiler data shows the loop body (`charAt` + `isWhitespace`) originally consumed ~99.8% of function time across 200,027 iterations; the hoisting cuts per-iteration overhead and aids JIT optimization, yielding a 16% runtime improvement. The trade-off is negligible: slightly higher memory use for two stack locals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 17% (0.17x) speedup for
StringUtils.isBlankinrewrite-core/src/main/java/org/openrewrite/internal/StringUtils.java⏱️ Runtime :
1.11 milliseconds→954 microseconds(best of129runs)📝 Explanation and details
The optimization caches
string.length()in a local variable and stores eachstring.charAt(i)result in a localcharbefore passing it toCharacter.isWhitespace, eliminating repeated virtual method calls and bounds checks inside the hot loop. Line profiler data shows the loop body (charAt+isWhitespace) originally consumed ~99.8% of function time across 200,027 iterations; the hoisting cuts per-iteration overhead and aids JIT optimization, yielding a 16% runtime improvement. The trade-off is negligible: slightly higher memory use for two stack locals.✅ Correctness verification report:
🌀 Click to see Generated Regression Tests
To edit these changes
git checkout codeflash/optimize-StringUtils.isBlank-mnn52r74and push.