Skip to content

Legislator page (sidebar: biography)#2159

Open
mertbagt wants to merge 14 commits into
codeforboston:mainfrom
mertbagt:legislator-bio
Open

Legislator page (sidebar: biography)#2159
mertbagt wants to merge 14 commits into
codeforboston:mainfrom
mertbagt:legislator-bio

Conversation

@mertbagt

@mertbagt mertbagt commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

biography portion of #2136

Checklist

  • On the frontend, I've made my strings translate-able.
  • I've made pages responsive and look good on mobile.

Screenshots

Public Profile aboutYou/Bio of a given Legislator shown as read-only to most users:

image

read-only result when Legislator has not edited their aboutYou/Bio:

image

Edit Form show to the pageOwner/Legislator in question:

image

Known issues

none

Steps to test/reproduce

  1. Go to ./legislators/profile?id=XBPiuP0JN5ZwAMXb19j68GJduuO2
  2. verify read-only public view of Biography section
  3. replace the above id with your id and be logged in
  4. verify biography section is now an editable form

@vercel

vercel Bot commented Jun 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
maple-dev Ready Ready Preview, Comment Jun 10, 2026 6:42am

Request Review

@Mephistic

Copy link
Copy Markdown
Collaborator

Is this ready for review? When I got to the test legislator page, I just see a perpetual loading indicator

@Mephistic

Copy link
Copy Markdown
Collaborator

We chatted about this at hack night - it turns out this doesn't play nicely with the Vercel preview deployments for whatever reason. I committed to running this locally to review it, as well as reviewing what exactly is causing the Vercel issues to see if it's easily fixable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants