Handle bill text size limit (#2169)#2171
Draft
Smoss wants to merge 2 commits into
Draft
Conversation
…. Introduced loading state and spinner for better user experience. Updated database functions to handle chunked document text storage in Firestore, ensuring bills exceeding size limits are properly managed. Added tests for document text storage behavior.
…n: .claude/ and .serena/
Smoss
requested review from
Mephistic,
alexjball,
kiminkim724,
mertbagt,
mvictor55,
nesanders,
sashamaryl and
timblais
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchBillResourceinfunctions/src/bills/bills.tsmoves oversizedDocumentTextinto an orderedcontentBlockssubcollection viafunctions/src/bills/contentBlocks.tsgetBillDocumentTextincomponents/db/bills.tsreturns inline text for normal bills and reassembles blocks for chunked onescomponents/bill/Summary.tsxfetches lazily when the "View Bill" modal opens, showing a Bootstrap spinner while loading; the "View Bill" button is shown wheneverDocumentTextORDocumentTextBlockCountis presentCloses #2169
Test plan
yarn testpasses (functions unit tests cover all 4 storage cases: inline, chunked, write-failure fallback, stale-blocks cleanup; UI test covers chunked reassembly, inline, and no-text paths)🤖 Generated with Claude Code