feat: add optional merge directives for registrars#10329
Open
michalsn wants to merge 2 commits into
Open
Conversation
michalsn
added
enhancement
memleakd
reviewed
Jun 20, 2026
Comment on lines
+401
to
+405
| All four de-duplicate, so the directives never *introduce* a duplicate value: a | ||
| value already in the list is not added again, and duplicate payload values are | ||
| collapsed (e.g. ``Merge::append(['x', 'x'])`` adds ``x`` once). Duplicates that | ||
| already exist in the current list are left as-is. They differ only in how they | ||
| treat a value that is *already present*: |
Contributor
There was a problem hiding this comment.
Small docs thought: should we mention that before() / after() throw when the payload contains the anchor itself?
| } | ||
| } elseif (is_int($key)) { | ||
| $current[] = $value; | ||
| } elseif (isset($current[$key]) && is_array($current[$key]) && is_array($value)) { |
Contributor
There was a problem hiding this comment.
Maybe I’m missing something, but should this also recurse when $value is an array and the current child is missing?
It looks like a nested directive in a brand-new subtree could otherwise be kept as a Merge object instead of being resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds optional
CodeIgniter\Config\Mergedirectives for Registrars, allowing packages and modules to explicitly control how registrar values are merged into existing config properties.The default registrar behavior remains unchanged and backward compatible: plain array values still use the current shallow merge behavior. Projects and packages that do not need finer control can continue using registrars exactly as before.
For cases that need more precise behavior, registrars can now opt into replacing values, merging nested arrays by key, appending or prepending list items, or positioning list items before or after an anchor.
Closes #9231
Checklist: