-
Notifications
You must be signed in to change notification settings - Fork 434
Check build hints at compile time instead of shipping them inert #5586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shai-almog
wants to merge
64
commits into
master
Choose a base branch
from
build-hint-annotations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
8d2cfcf
Check build hints at compile time instead of shipping them inert
shai-almog d243535
Commit the catalog sources that .gitignore was swallowing
shai-almog d727c7d
Stop the bootstrap doing its work at import time
shai-almog 96bff90
Make the generated docs and sources survive the ASCII and prose gates
shai-almog a343fe3
Give ThreadSafeDatabaseTest headroom under the FormTest timeout
shai-almog 0edef42
Refuse to migrate a project that never runs process-annotations
shai-almog 2803847
Do not migrate the guide's snippet project, and keep Settings from du…
shai-almog 53da7c3
Defer the generated-project templates to a follow-up
shai-almog 8b50565
Annotate inside the integration test, not in the archetype
shai-almog b2e0e86
Four migration and Settings defects from review
shai-almog fd05dfa
Require the process-annotations binding on the module that owns the m…
shai-almog 3037e76
Require an execution that can actually see compiled classes
shai-almog af8ff86
Stop the generated simulator schema duplicating the hand-written one
shai-almog 586e6bc
Prove the annotations are processed instead of predicting it
shai-almog b1dff60
Round-trip the rollback snapshot, and stop trusting a stale manifest
shai-almog 76cd1dc
Preserve source bytes, and stop comments confusing the annotation sca…
shai-almog 8be6d5f
Refuse a build whose annotations were never processed
shai-almog fb5a6c7
Do not refuse a build over an annotation that sets nothing
shai-almog 51fb76a
Tell a current annotation manifest from last build's
shai-almog 9c5a586
Give the same answer whether or not target/classes was cleaned
shai-almog 43f73f1
Merge remote-tracking branch 'origin/master' into build-hint-annotations
shai-almog b6f16f2
Catalogue the ten build hints the Wear change added
shai-almog eb58dac
Write the new catalog rows in the guide's own voice
shai-almog a5f8dbb
Merge remote-tracking branch 'origin/master' into build-hint-annotations
shai-almog 9437da7
Stop the catalog gate claiming coverage it never checked
shai-almog 2cf0842
Verify the migration the way a real build runs
shai-almog 01816a1
Read the project as configured, and the source as code
shai-almog d013397
Retry the repository failure that was not on the list
shai-almog 3fbc47f
Ask the build where it wrote, and key the gate by what it reads
shai-almog 9162f41
Collapse the two capture-record spellings, and stop guessing
shai-almog 392e2a5
Let the simulator see a duplicate declaration too
shai-almog 01e471f
Take the published hints back out on a simulator reload
shai-almog cd00b3a
Read a text block the way its own language does
shai-almog b465921
Find the hints that live in a table
shai-almog a1fd203
Render the guide's hint table instead of committing it
shai-almog ffb6715
Migrate a legacy spelling to the name the build emits
shai-almog 7e8e7e2
Run the docs checks when the table's inputs change
shai-almog 186a75c
Accept what the runtime accepts, and ask Maven where the sources are
shai-almog a83dbff
Identify a class by what it declares, not where it sits
shai-almog 7c6d949
Describe the plist keys we inject, individually
shai-almog d29969e
Ask about the main class, not about every class file
shai-almog 3235077
Refuse the value we cannot read, and read declarations as code
shai-almog 80e6c2a
Find the main class by what declares it, everywhere
shai-almog dc257e1
Migrate only a value already spelled the way the build reads it
shai-almog a992843
Stop skipping the attribute the orphan filter reads
shai-almog d8c148a
Count braces over code, and read the whole file
shai-almog 2034b41
Follow the language's own rules for imports, packages and scope
shai-almog bb30a7e
Stop a hint value from forging the digest around it
shai-almog bd903c4
Store the spelling that works, and put the import above the annotations
shai-almog 73974eb
Read imports forwards, and triple quotes by language
shai-almog fcc1c37
Guard the form the ownership rule was not applied to
shai-almog e4a5123
Judge a Kotlin nested path only as far as Kotlin lets us
shai-almog 272939c
Tell a Kotlin function segment from a deleted nested type
shai-almog 8ee8a47
Merge master, and catalogue the hints it brought
shai-almog 4cdf81c
Find the package declaration in code, and clear the whole of it
shai-almog 5397cf7
Treat a modifier on an earlier line as part of the declaration
shai-almog b80eadf
Add a hint at the value the build already uses, and let a conflict be…
shai-almog 57850e5
Record no default where the build has none, and read a build package
shai-almog 7c0c203
Read a qualified import component by component
shai-almog 78ee230
Ask for a value when the build has none to inherit
shai-almog 5040621
Read a package name the way an import is read, and see a live misplac…
shai-almog d4e4516
Name a found class properly, keep looking, and read imports as declar…
shai-almog f3194ba
Close a Kotlin block comment where Kotlin closes it, and read @Name a…
shai-almog 5957d2e
Read the manifest out of the app's own jar, and the package name whole
shai-almog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.