Skip to content

fix: isolate ffmpeg from signals when recording #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugodutka merged 1 commit into from
Mar 30, 2026
+1 −0
Merged

fix: isolate ffmpeg from signals when recording #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pd/internal/desktop/record.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ func (d *Desktop) StartRecording(opts RecordingOptions) (*RecordingHandle, error
cmd.Env = d.Env()
cmd.Stdout = logFile
cmd.Stderr = logFile
cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}

if err := cmd.Start(); err != nil {
return nil, fmt.Errorf("start ffmpeg recorder: %w", err)
Expand Down
Loading