Skip to content

fix(.github/workflows): detect PR-changed modules via the pulls files API #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bpmct merged 3 commits into from
Aug 11, 2026
Merged

fix(.github/workflows): detect PR-changed modules via the pulls files API #1046

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4917f58
fix(.github/workflows): detect PR-changed modules via the pulls files…
bpmct Aug 11, 2026
2ae8322
fix(.github/workflows): use merge-commit parent diff instead of gh api
bpmct Aug 11, 2026
cdd6d6e
fix(.github/workflows): fetch merge commit parents for HEAD^1 diff
bpmct Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/module-scorecard-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ jobs:
- name: Checkout
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0
# The merge commit plus both parents, for the HEAD^1 diff below.
fetch-depth: 2

- name: Setup Bun
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2
Expand All @@ -45,10 +46,15 @@ jobs:

- name: Determine changed modules
id: changed
env:
BASE_SHA: ${{ github.event.pull_request.base.sha }}
# The checkout is GitHub's test merge commit (PR head merged into
# current main), so HEAD^1 is the exact main tip this PR is applied
# to and the diff is precisely what the PR changes. Diffing against
# github.event.pull_request.base.sha is wrong: that SHA is the base
# tip from when the PR was opened, so on stale PRs it picks up every
# module merged to main since the PR branched and scores unrelated
# modules (REG-74).
run: |
MODULES=$(git diff --name-only "${BASE_SHA}"...HEAD | grep -oP '^registry/coder/modules/\K[^/]+' | sort -u | paste -sd, -)
MODULES=$(git diff --name-only HEAD^1 HEAD | { grep -oP '^registry/coder/modules/\K[^/]+' || true; } | sort -u | paste -sd, -)
echo "modules=${MODULES}" >> "${GITHUB_OUTPUT}"
echo "Changed modules: ${MODULES:-none}"

Expand Down