feat(health-check): default the ALB health route to Laravel's /up#86
Merged
Conversation
Flip the target-group health check path default from /health to /up — Laravel's built-in health route (11+). /up boots the full framework and returns 200 only on a clean boot (500 otherwise), so it satisfies YOLO's "exercise PHP so a broken boot still fails the check" requirement without the app needing a hand-rolled /health route. The path stays overridable via tasks.web.health-check.path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I made a thing! 🥳
Great! Now please answer the following questions to help out your assigned reviewer:
What problems are you solving?
/health, a route every app had to hand-roll. Flipping the default to/up— Laravel's built-in health route (11+) — means a stock Laravel app is health-checkable out of the box./upboots the full framework and returns200only on a clean boot (500otherwise), so it still satisfies YOLO's "exercise PHP so a broken boot fails the check" requirement — no static Caddy 200 that would mask a broken boot.Is there anything the reviewer needs to know to deploy this?
tasks.web.health-check.path— only the default changed.TargetGroupimplementsSynchronisesConfiguration, so this reaches live target groups on the nextyolo sync— it'llModifyTargetGroupany existing group still on/healthover to/up. An already-deployed app that defines/healthbut not/upwould start failing health checks after a sync. Stock Laravel apps (CL included) already ship/up, so no impact there — just eyeball any older app that predates the/uproute before syncing it.Changes
TargetGroup::reconcilableHealthCheck()default/health→/up(+ rationale comment)./up; the override test now sets/healthso it still proves the manifest override bites./upboot behaviour and theDiagnosingHealthevent, linked to Laravel's health-route docs.Verification
🤖 Generated with Claude Code