Skip to content

Enable subprocess test coverage gathering#75

Merged
zsimic merged 1 commit intomainfrom
more-coverage
Mar 20, 2026
Merged

Enable subprocess test coverage gathering#75
zsimic merged 1 commit intomainfrom
more-coverage

Conversation

@zsimic
Copy link
Contributor

@zsimic zsimic commented Mar 19, 2026

This catches ~10 more lines covered

@zsimic zsimic requested review from nedbat and thatch March 19, 2026 00:44
@coveralls
Copy link

Pull Request Test Coverage Report for Build 23274217369

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 98.476%

Totals Coverage Status
Change from base Build 23273021032: 0.3%
Covered Lines: 2649
Relevant Lines: 2690

💛 - Coveralls

@thatch
Copy link
Member

thatch commented Mar 19, 2026

I'm a fly on the wall to know if this is better than the defaults -- I thought the .pth handled patching for us now.

@nedbat
Copy link

nedbat commented Mar 19, 2026

You do need patch = subprocess for the .pth to have an effect. I was conservative and didn't want it being enabled automatically.

@zsimic zsimic merged commit 9727737 into main Mar 20, 2026
7 checks passed
@zsimic zsimic deleted the more-coverage branch March 20, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants