Skip to content

[Security] Fix CodeQL alert #32: XML internal entity expansion #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colin-d-fried wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Security] Fix CodeQL alert #32: XML internal entity expansion #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vulnerable_xxe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import xml.etree.ElementTree as ET
import defusedxml.ElementTree as ET
Copy link
Copy Markdown

@cursor cursor Bot Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New dependency defusedxml missing from project dependencies

High Severity

The import was changed to defusedxml.ElementTree but defusedxml is not declared in Pipfile or Pipfile.lock (and no requirements.txt exists). This means the application will crash at startup with an ImportError, and the intended XXE security fix will not actually be deployed. The security vulnerability remains exploitable because the fix cannot run.

Fix in Cursor Fix in Web

from flask import Flask, request
from lxml import etree
import xml.sax
Expand Down
Loading