Add a libpython3.dylib to support ABI3 applications - #885
Conversation
Note that this is not for extensions like numpy. It is for executbales like lldb.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/30320622228. Examine the logs at this URL for more detail. |
|
Thanks, this LGTM! Once this is approved/merged, we're gonna need this on all the maintenance branches too |
|
We need to figure out how to port it to dev given #842 |
I was mainly concerned with needing this for |
| - for f in ${CONDA_PREFIX}/lib/python*/_sysconfig*.py; do echo "Checking $f:"; if [[ `rg @[^@]*@ $f` ]]; then echo "FAILED ON $f"; cat $f; exit 1; fi; done # [linux64 or osx] | ||
| - test ! -f ${PREFIX}/lib/libpython${PKG_VERSION%.*}.a # [unix] | ||
| - test ! -f ${PREFIX}/lib/libpython${PKG_VERSION%.*}.nolto.a # [unix] | ||
| - test -f ${PREFIX}/lib/libpython3${SHLIB_EXT} # [unix] |
There was a problem hiding this comment.
I think we have to restrict this to the non-debug ABI?
| - test -f ${PREFIX}/lib/libpython3${SHLIB_EXT} # [unix] | |
| - test -f ${PREFIX}/lib/libpython3${SHLIB_EXT} # [unix and (build_type != "debug")] |
You need |
Of course. I just meant that 3.15 only goes GA in October. |
Yes, but adding a feature to refactor in October seems bad. We should port |
|
I'm not saying we should leave it in a broken state; just that we'd have 3 months to fix it, whereas for the other python versions it would be useful right away |
|
I really don't want to put |
Note that this is not for extensions like numpy. It is for executbales like lldb.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)See conda-forge/lldb-feedstock#110. cc @h-vetinari