add asyncComplete support to sdk Task base class#136
Draft
klouds27 wants to merge 1 commit into
Draft
Conversation
asyncComplete was present on WorkflowTask but not exposed through the sdk, making it impossible to create async http or event tasks without subclassing as a workaround. adds the field to Task<T> alongside optional and startDelay, wires it through toWorkflowTask() and restores it from the WorkflowTask constructor. any task type can now call .asyncComplete(true). Signed-off-by: klouds27 <adalwolf@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
v1r3n
reviewed
Jul 20, 2026
v1r3n
left a comment
v1r3n
left a comment
Contributor
There was a problem hiding this comment.
Looks good. The base task builder now preserves asyncComplete when converting both to and from WorkflowTask, and the added round-trip test verifies the public HTTP task path. I found no correctness, security, or test-coverage issue requiring changes.
Contributor
|
@klouds27 make it ready for review when ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asyncCompleteexists onWorkflowTaskbut is not exposed through the sdk, making it impossible to define async http or event tasks without subclassing as a workaround.adds the field to
Task<T>alongsideoptionalandstartDelay, wires it throughtoWorkflowTask()and restores it from theWorkflowTaskconstructor. any task type can now call.asyncComplete(true).