feat(workflow): add LambdaTask builder for TaskType.LAMBDA#440
Open
rahul188 wants to merge 1 commit into
Open
Conversation
Closes conductor-oss#427 TaskType.LAMBDA existed in the enum but had no builder class, so LAMBDA tasks could only be constructed from raw dicts via the Python SDK. Add a LambdaTask builder that mirrors InlineTask: it sets scriptExpression from the script argument and merges any bindings into input_parameters. Signed-off-by: rahul188 <rahulkuchhadia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #427
TaskType.LAMBDAis present in the SDK's enum, but there was noLambdaTaskbuilder class, so LAMBDA tasks could only be constructed from raw dicts. This adds the missing builder.Change
Add
src/conductor/client/workflow/task/lambda_task.pywith aLambdaTaskthat mirrorsInlineTask: it setsscriptExpressionfrom thescriptargument and merges anybindingsintoinput_parameters. The resulting workflow task serializes withtype: "LAMBDA"and the expectedinputParameters, matching the server-side shape in the issue.Tests
Added
tests/unit/workflow/test_lambda_task.py, covering thescriptExpressionconstruction, theto_workflow_task()type (LAMBDA), and bindings merge. Both pass against the SDK.