-
Notifications
You must be signed in to change notification settings - Fork 60
π¨ Update registry.access.redhat.com/ubi9/go-toolset Docker tag to v9 (main) #3375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ | |
|
|
||
| ## Build | ||
|
|
||
| FROM registry.access.redhat.com/ubi9/go-toolset:1.26.3@sha256:17c888d75753f128f6cbdc5587932c3abd2632ca8e0931aa27b9a60c7a75ac62 AS build | ||
| FROM registry.access.redhat.com/ubi9/go-toolset:9.8-1784190466@sha256:f99dd81b20e5971ef9f63a51ac27cf0aa591ff9921d021490548b67fd9b17144 AS build | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] correctness After this change, the two Dockerfiles track Go versions differently: Dockerfile uses golang:1.26.3 (explicitly Go-version-pinned), while Dockerfile.dist uses go-toolset:9.8-1784190466 (UBI-release-pinned, Go version opaque). This divergence makes it harder to maintain Go version consistency across build paths. Suggested fix: Keep Dockerfile.dist on Go-version-based tags (e.g., go-toolset:1.26.3) to maintain parity with Dockerfile. |
||
|
|
||
| ARG TARGETOS | ||
| ARG TARGETARCH | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[high] correctness
The base image tag changes from Go-version-based (1.26.3) to UBI9-release-based (9.8-1784190466), switching the version dimension entirely. The project requires Go 1.26.3 (go.mod, Dockerfile), but the new tag does not indicate which Go version is bundled. Future Renovate updates will track UBI releases rather than Go versions, risking silent Go toolchain changes.
Suggested fix: Verify the new image contains Go 1.26.3 (e.g., podman run --rm
go version). Reconfigure Renovate to track Go-version-based tags for go-toolset via packageRules or versioning settings in renovate.json.