Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile.dist
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

## Build

FROM registry.access.redhat.com/ubi9/go-toolset:1.26.3@sha256:17c888d75753f128f6cbdc5587932c3abd2632ca8e0931aa27b9a60c7a75ac62 AS build
FROM registry.access.redhat.com/ubi9/go-toolset:9.8-1784190466@sha256:f99dd81b20e5971ef9f63a51ac27cf0aa591ff9921d021490548b67fd9b17144 AS build

Check failure on line 19 in Dockerfile.dist

View workflow job for this annotation

GitHub Actions / Test

Containerfile version incompatible, saw 9.8, running with version: 1.26.3

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[high] correctness

The base image tag changes from Go-version-based (1.26.3) to UBI9-release-based (9.8-1784190466), switching the version dimension entirely. The project requires Go 1.26.3 (go.mod, Dockerfile), but the new tag does not indicate which Go version is bundled. Future Renovate updates will track UBI releases rather than Go versions, risking silent Go toolchain changes.

Suggested fix: Verify the new image contains Go 1.26.3 (e.g., podman run --rm go version). Reconfigure Renovate to track Go-version-based tags for go-toolset via packageRules or versioning settings in renovate.json.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] correctness

After this change, the two Dockerfiles track Go versions differently: Dockerfile uses golang:1.26.3 (explicitly Go-version-pinned), while Dockerfile.dist uses go-toolset:9.8-1784190466 (UBI-release-pinned, Go version opaque). This divergence makes it harder to maintain Go version consistency across build paths.

Suggested fix: Keep Dockerfile.dist on Go-version-based tags (e.g., go-toolset:1.26.3) to maintain parity with Dockerfile.


ARG TARGETOS
ARG TARGETARCH
Expand Down
Loading