go.mod: don't enforce latest go version#351
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
9cee6c6 to
26ac903
Compare
|
Added two commits;
|
|
Hm.. yeah, CodeQL looks to be correct; probably best to add permissions as well I also think I should add |
Commit e9d8229 updated the version of go to use for this module, but also updated the go directive in go.mod, preventing users of this module to use lower versions. For modules used as library, Go generally recommends supporting at least the current stable and "oldstable" (stable -1) releases. This patch: - downgrades the go directive in go.mod to go1.25 - updates github actions workflows to test both the specified version (1.26) and the version specified in go.mod (minimal version). - sets GOTOOLCHAIN=local to prevent implicit go upgrades Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Avoid running the full `go test` invocation (including build) as root. Using `-exec sudo` ensures only the test binary is executed with elevated privileges, while compilation and caching remain unprivileged. This prevents root-owned build artifacts and aligns better with module-based workflows, while still allowing tests that require root (e.g., via `-test.root`) to run correctly. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
fail-fast has no effect if there's no matrix (without a matrix it's always fail-fast). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
26ac903 to
2fb34a8
Compare
|
@chewi PTAL :D |
|
I'm not familiar with the CI bits, but simply changing go.mod was enough for us. |
|
Yeah, I noticed as well that the release workflow uses a third-party archived / unmaintained action; probably should be looked at to replace it with something maintained (or the accelerated-container-image/.github/workflows/release.yml Lines 116 to 123 in 155d50b ☝️ that action looks to be archived in 2024; https://github.com/marvinpinto/action-automatic-releases |
Commit e9d8229 updated the version of go to use for this module, but also updated the go directive in go.mod, preventing users of this module to use lower versions.
For modules used as library, Go generally recommends supporting at least the current stable and "oldstable" (stable -1) releases.
This patch:
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: