add coverage for IsXXX helpers, and use stdlib unwrapping for customMessage#23
Open
thaJeztah wants to merge 2 commits into
Open
add coverage for IsXXX helpers, and use stdlib unwrapping for customMessage#23thaJeztah wants to merge 2 commits into
thaJeztah wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates customMessage to participate in Go’s standard error unwrapping (via Unwrap()), and expands test coverage to systematically verify the behavior of the IsXxx helper functions across sentinel errors, %w wrapping, Moby-style interface-based errors, and errors.Join.
Changes:
- Replace
customMessage’s customIs/Asbehavior with a standardUnwrap()implementation. - Consolidate
IsXxxhelper testing into a single table-driven test that exercises sentinel, wrapped, interface-based, and joined errors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| errors.go | Makes customMessage use stdlib unwrapping by adding Unwrap() and removing bespoke Is/As handling. |
| errors_test.go | Adds broad, table-driven coverage for all IsXxx helpers including wrapping and errors.Join. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Replace custom Is/As implementations with Unwrap and rely on the standard errors package traversal. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.