Skip to content

Update typeurl/v2 to v2.3.0, errdefs to v1.0.0#25

Merged
estesp merged 2 commits into
containerd:mainfrom
liggitt:main
Jun 10, 2026
Merged

Update typeurl/v2 to v2.3.0, errdefs to v1.0.0#25
estesp merged 2 commits into
containerd:mainfrom
liggitt:main

Conversation

@liggitt

@liggitt liggitt commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Picks up containerd/typeurl#51 and drops out gogo dependency

Also bumps pkg to use errdefs v1.0.0 tag

cc @samuelkarp

@samuelkarp

Copy link
Copy Markdown
Member

The project-checks action likely needs to be bumped.

@samuelkarp

Copy link
Copy Markdown
Member

We should take #24 and then you can rebase this on top.

@liggitt

liggitt commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

ah, I was just trying to figure out where that break was coming from

@samuelkarp

Copy link
Copy Markdown
Member

#24 is merged, can you rebase now?

Signed-off-by: Jordan Liggitt <liggitt@google.com>
@liggitt

liggitt commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

done

Signed-off-by: Jordan Liggitt <liggitt@google.com>
@liggitt

liggitt commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

I just noticed https://github.com/containerd/errdefs/tags has a v1.0.0 errdefs/pkg never updated to refer to ... bumped that here as well in case we want to tag pkg/v1.0.0 once this merges

(happy to separate that out if desired)

@liggitt liggitt changed the title Update typeurl/v2 to v2.3.0 Update typeurl/v2 to v2.3.0, errdefs to v1.0.0 Jun 9, 2026
@thaJeztah

Copy link
Copy Markdown
Member

in case we want to tag pkg/v1.0.0 once this merges

ISTR we still wanted some wiggle-room in the pkg/xxx packages, so potentially that could be a pkg/v0.3.1 or pkg/v0.4.0 first.

@liggitt

liggitt commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

in case we want to tag pkg/v1.0.0 once this merges

ISTR we still wanted some wiggle-room in the pkg/xxx packages, so potentially that could be a pkg/v0.3.1 or pkg/v0.4.0 first.

ok, no opinion either way as long as we get a tag that includes this

I assume it's still ok for errdefs/pkg to reference v1.0.0 of errdefs

@thaJeztah

Copy link
Copy Markdown
Member

I assume it's still ok for errdefs/pkg to reference v1.0.0 of errdefs

Yes, I think that's a sane option; usually we try to keep dependencies low, but I think v1.0.0 is a clearer "contract" (we expect v1.0.0)

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit d09a305 into containerd:main Jun 10, 2026
7 checks passed
@liggitt

liggitt commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

thanks, I'll watch for a pkg/vX.Y.Z tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants