Skip to content

ci: migrate GHA to task, remove duplicate unit test job#223

Merged
dmcgowan merged 1 commit into
containerd:mainfrom
dmcgowan:task-gha-cleanup
Jun 9, 2026
Merged

ci: migrate GHA to task, remove duplicate unit test job#223
dmcgowan merged 1 commit into
containerd:mainfrom
dmcgowan:task-gha-cleanup

Conversation

@dmcgowan

@dmcgowan dmcgowan commented Jun 9, 2026

Copy link
Copy Markdown
Member

Add test:fuzz and cross-compilation support to build:shim in Taskfile.yml. Update fuzz and build-shim workflows to use task. Remove the duplicate tests job introduced alongside the fuzz job.

Add test:fuzz and cross-compilation support to build:shim in
Taskfile.yml. Update fuzz and build-shim workflows to use task.
Remove the duplicate tests job introduced alongside the fuzz job.

Signed-off-by: Derek McGowan <derek@mcg.dev>
Copilot AI review requested due to automatic review settings June 9, 2026 06:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates GitHub Actions CI logic around task by moving fuzz testing and shim cross-compilation steps into Taskfile.yml, and removing a redundant unit test job from the workflow configuration.

Changes:

  • Extend build:shim to support cross-compilation via GOOS/GOARCH overrides.
  • Add a test:fuzz task and switch the CI fuzz workflow to invoke it via task.
  • Remove a duplicate unit test job from CI and update the shim build workflow to use task build:shim.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
Taskfile.yml Adds cross-compilation support for shim builds and introduces a reusable fuzz-testing task.
.github/workflows/ci.yml Updates fuzz job to run via task and removes the redundant unit test job block.
.github/workflows/build-shim.yml Migrates shim build steps to task build:shim with GOOS/GOARCH provided by the matrix.
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:151

  • Removing the dedicated unit test job also removes the only go test -race execution from CI (there are no remaining -race invocations in this workflow). If the intent was only to remove duplication, consider keeping a race-detector run (e.g., on ubuntu-latest) to avoid losing coverage for data races.
  #
  # Fuzz tests
  #
  fuzz:
    name: Fuzz Tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Taskfile.yml
Comment thread Taskfile.yml

@akerouanton akerouanton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 7e0fe27 into containerd:main Jun 9, 2026
16 checks passed
@dmcgowan dmcgowan deleted the task-gha-cleanup branch June 9, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants