-
Notifications
You must be signed in to change notification settings - Fork 2
feat(e2e-web): shared Playwright E2E suite for web SDK implementations [NT-3466] #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
David Nalchevanidze (nalchevanidze)
wants to merge
26
commits into
main
Choose a base branch
from
NT-3466-shared
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
a92b176
feat(rendering): handle rendering concerns framework-agnostic; fix vi…
nalchevanidze 4f4b774
Merge branch 'main' into NT-3466-shared
nalchevanidze d999fe4
refactor(web-sdk_angular): rename testIdPrefix to testId on EntryCard
nalchevanidze 347d703
docs(web-sdk_angular): improve liveRead comment to explain the ?? fal…
nalchevanidze a6b566f
refactor(web-sdk_angular): generalize fromSdkState to accept thunk or…
nalchevanidze b7d684b
docs(e2e-web): add intent comments to flag-view-tracking consent tests
nalchevanidze 6628a57
refactor(e2e-web): move flag-view-tracking intent into test titles
nalchevanidze 344d3b5
docs(web-sdk_angular): clarify booleanFlag consent gate is for tracki…
nalchevanidze c2bd146
docs(e2e-web): add README with purpose, setup, and how IMPLEMENTATION…
nalchevanidze 83e9512
docs(e2e-web): expand README with IMPLEMENTATION/APP_PORT rationale a…
nalchevanidze d7322dd
docs(e2e-web): clarify adding new implementation steps and shared setup
nalchevanidze b01437d
docs(e2e-web): simplify adding new implementation example
nalchevanidze 62f1397
refactor(e2e-web): remove redundant implementation:setup:e2e aliases;…
nalchevanidze c567631
fix(e2e-web): update root setup:e2e scripts to call lib/e2e-web directly
nalchevanidze f3c4779
fix(e2e-web,implementations): use === 'true' for env var boolean checks
nalchevanidze 3f16a7f
fix(e2e-web): load implementation .env before suite runs
nalchevanidze aa3d186
fix(web-sdk_angular): always enable preview panel
nalchevanidze a827ba0
revert(web-sdk_angular): restore preview panel gate to !== 'false'
nalchevanidze 0fbcf95
Merge branch 'main' into NT-3466-shared
nalchevanidze b18b4b8
feat(web-sdk_angular): load .env via environment.ts file replacement
nalchevanidze 60d54c5
fix(web-sdk_angular): create environments dir if missing in generate:env
nalchevanidze 8c29b47
fix(web-sdk_angular): type environment stub and use ?? over ||
nalchevanidze d44089f
feat(web-sdk_angular): use .env as source of truth for e2e via file r…
nalchevanidze 8327f9d
fix(web-sdk_angular): use pnpm tsx over relative node_modules path
nalchevanidze 5c3c672
feat(web-sdk_angular): simplify env loading — drop fileReplacements, …
nalchevanidze 55e65b1
fix(web-sdk_angular): use .env only in generate-env, drop .env.exampl…
nalchevanidze File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { parse } from 'dotenv' | ||
| import { mkdirSync, readFileSync, writeFileSync } from 'node:fs' | ||
|
|
||
| const env = parse(readFileSync('.env')) | ||
|
|
||
| const entries = Object.keys(env) | ||
| .map((k) => ` ${k}: ${JSON.stringify(env[k])}`) | ||
| .join(',\n') | ||
|
|
||
| const content = [ | ||
| '// Generated by scripts/generate-env.ts — do not edit manually', | ||
| 'export const environment = {', | ||
| entries, | ||
| '}', | ||
| '', | ||
| ].join('\n') | ||
|
|
||
| mkdirSync('src/environments', { recursive: true }) | ||
| writeFileSync('src/environments/environment.ts', content) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.