Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## v1.11.1

### Apr 06, 2026

- Fix: `setTimeout` now applies to OkHttp connect, read, and write timeouts (previously only connect). Optional `setConnectTimeout`, `setReadTimeout`, and `setWriteTimeout` override individual phases.
- Build: Maven Surefire updated with `surefire-junit-platform` so JUnit 5 tests run when enabled.

## v1.11.0

### Feb 09, 2026
Expand Down
25 changes: 17 additions & 8 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<artifactId>cms</artifactId>
<packaging>jar</packaging>
<name>contentstack-management-java</name>
<version>1.11.0</version>
<version>1.11.1</version>
<description>Contentstack Java Management SDK for Content Management API, Contentstack is a headless CMS with an
API-first approach
</description>
Expand Down Expand Up @@ -89,18 +89,19 @@
<maven-javadoc-plugin.version>3.0.0</maven-javadoc-plugin.version>
<dotenv-source.version>5.2.2</dotenv-source.version>
<rxjava-source.version>3.1.12</rxjava-source.version>
<retrofit-source.version>2.12.0</retrofit-source.version>
<converter-gson-version>2.12.0</converter-gson-version>
<okhttp.version>5.1.0</okhttp.version>
<retrofit-source.version>3.0.0</retrofit-source.version>
<converter-gson-version>3.0.0</converter-gson-version>
<okhttp.version>5.3.2</okhttp.version>
<jococo-plugin.version>0.8.13</jococo-plugin.version>
<lombok-source.version>1.18.38</lombok-source.version>
<lombok-source.version>1.18.42</lombok-source.version>
<junit-jupiter.version>5.11.4</junit-jupiter.version>
<junit-jupiter-engine.version>5.10.1</junit-jupiter-engine.version>
<gson.version>2.13.2</gson.version>
<maven-site-plugin.version>3.3</maven-site-plugin.version>
<maven-gpg-plugin.version>1.5</maven-gpg-plugin.version>
<maven-compiler-plugin.version>3.8.0</maven-compiler-plugin.version>
<maven-release-plugin.version>2.5.3</maven-release-plugin.version>
<maven-surefire-plugin.version>3.5.2</maven-surefire-plugin.version>
</properties>

<dependencies>
Expand Down Expand Up @@ -242,7 +243,14 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.0.0-M5</version>
<version>${maven-surefire-plugin.version}</version>
<dependencies>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>surefire-junit-platform</artifactId>
<version>${maven-surefire-plugin.version}</version>
</dependency>
</dependencies>
<configuration>
<includes>
<!-- Run all test files following Maven naming conventions -->
Expand All @@ -252,8 +260,9 @@
<include>**/*TestCase.java</include>
<include>**/*TestSuite.java</include>
</includes>
<reportsDirectory>${project.build.directory}/surefire-reports</reportsDirectory>
<skipTests>true</skipTests>
<reportsDirectory>${project.build.directory}/surefire-reports</reportsDirectory>
<!-- Skip during default lifecycle (e.g. publish); run tests locally with: mvn test -DskipTests=false -->
<skipTests>true</skipTests>
<testFailureIgnore>true</testFailureIgnore>
</configuration>
</plugin>
Expand Down
37 changes: 36 additions & 1 deletion src/main/java/com/contentstack/cms/Contentstack.java
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,9 @@ public static class Builder {
private String port = Util.PORT; // Default PORT for Contentstack API
private String version = Util.VERSION; // Default Version for Contentstack API
private int timeout = Util.TIMEOUT; // Default timeout 30 seconds
private Integer connectTimeoutSeconds;
private Integer readTimeoutSeconds;
private Integer writeTimeoutSeconds;
private Boolean retry = Util.RETRY_ON_FAILURE;// Default base url for contentstack
private RetryConfig retryConfig = RetryConfig.defaultConfig();
/**
Expand Down Expand Up @@ -687,10 +690,37 @@ public Builder setVersion(@NotNull String version) {
* @return Client timeout
*/
public Builder setTimeout(int timeout) {
validateTimeoutSeconds(timeout, "timeout");
this.timeout = timeout;
return this;
}

public Builder setReadTimeout(int readTimeoutSeconds) {
validateTimeoutSeconds(readTimeoutSeconds, "readTimeout");
this.readTimeoutSeconds = readTimeoutSeconds;
return this;
}

public Builder setWriteTimeout(int writeTimeoutSeconds) {
validateTimeoutSeconds(writeTimeoutSeconds, "writeTimeout");
this.writeTimeoutSeconds = writeTimeoutSeconds;
return this;
}

public Builder setConnectTimeout(int connectTimeoutSeconds) {
validateTimeoutSeconds(connectTimeoutSeconds, "connectTimeout");
this.connectTimeoutSeconds = connectTimeoutSeconds;
return this;
}

private static void validateTimeoutSeconds(int seconds, String name) {
if (seconds <= 0) {
throw new IllegalArgumentException(name + " must be positive.");
}
}



/**
* Create a new connection pool with tuning parameters appropriate for a
* single-user application. The tuning parameters in this pool are
Expand Down Expand Up @@ -840,11 +870,16 @@ private void validateClient(Contentstack contentstack) {
}

private OkHttpClient httpClient(Contentstack contentstack, Boolean retryOnFailure) {
int connectSec = this.connectTimeoutSeconds != null ? this.connectTimeoutSeconds : this.timeout;
int readSec = this.readTimeoutSeconds != null ? this.readTimeoutSeconds : this.timeout;
int writeSec = this.writeTimeoutSeconds != null ? this.writeTimeoutSeconds : this.timeout;
OkHttpClient.Builder builder = new OkHttpClient.Builder()
.connectionPool(this.connectionPool)
.addInterceptor(logger())
.proxy(this.proxy)
.connectTimeout(Duration.ofSeconds(this.timeout))
.connectTimeout(Duration.ofSeconds(connectSec))
.readTimeout(Duration.ofSeconds(readSec))
.writeTimeout(Duration.ofSeconds(writeSec))
.retryOnConnectionFailure(retryOnFailure);

// Add either OAuth or traditional auth interceptor
Expand Down
63 changes: 63 additions & 0 deletions src/test/java/com/contentstack/cms/ContentstackUnitTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import java.net.Proxy;
import java.util.HashMap;
import java.util.Map;
import java.util.concurrent.TimeUnit;

public class ContentstackUnitTest {

Expand Down Expand Up @@ -167,6 +168,68 @@ void setTimeout() {
Assertions.assertEquals(3, contentstack.timeout);
}

@Test
void setTimeoutZeroThrows() {
Assertions.assertThrows(IllegalArgumentException.class,
() -> new Contentstack.Builder().setTimeout(0));
}

@Test
void setTimeoutNegativeThrows() {
Assertions.assertThrows(IllegalArgumentException.class,
() -> new Contentstack.Builder().setTimeout(-1));
}

@Test
void setReadTimeoutZeroThrows() {
Assertions.assertThrows(IllegalArgumentException.class,
() -> new Contentstack.Builder().setReadTimeout(0));
}

@Test
void setWriteTimeoutNegativeThrows() {
Assertions.assertThrows(IllegalArgumentException.class,
() -> new Contentstack.Builder().setWriteTimeout(-5));
}

@Test
void setConnectTimeoutInvalidThrows() {
Assertions.assertThrows(IllegalArgumentException.class,
() -> new Contentstack.Builder().setConnectTimeout(-1));
}

@Test
void okHttpTimeoutsMatchSetTimeout() {
Contentstack client = new Contentstack.Builder().setTimeout(45).build();
OkHttpClient ok = (OkHttpClient) client.instance.callFactory();
Assertions.assertEquals(45_000, ok.connectTimeoutMillis());
Assertions.assertEquals(45_000, ok.readTimeoutMillis());
Assertions.assertEquals(45_000, ok.writeTimeoutMillis());
}

@Test
void okHttpDefaultTimeoutsUseUtilTimeout() {
Contentstack client = new Contentstack.Builder().build();
OkHttpClient ok = (OkHttpClient) client.instance.callFactory();
int expectedMs = (int) TimeUnit.SECONDS.toMillis(30);
Assertions.assertEquals(expectedMs, ok.connectTimeoutMillis());
Assertions.assertEquals(expectedMs, ok.readTimeoutMillis());
Assertions.assertEquals(expectedMs, ok.writeTimeoutMillis());
}

@Test
void okHttpPerLegOverridesFallBackToSetTimeout() {
Contentstack client = new Contentstack.Builder()
.setTimeout(10)
.setReadTimeout(90)
.build();
OkHttpClient ok = (OkHttpClient) client.instance.callFactory();
Assertions.assertEquals(10_000, ok.connectTimeoutMillis());
Assertions.assertEquals(90_000, ok.readTimeoutMillis());
Assertions.assertEquals(10_000, ok.writeTimeoutMillis());
Assertions.assertEquals(10, client.timeout);
}

@Test
void testSetAuthtoken() {
Contentstack contentstack = new Contentstack.Builder()
Expand Down
Loading