refactor: remove Newtonsoft.Json package and migrate template attributes to System.Text.Json#44
Merged
Merged
Conversation
…tes to System.Text.Json - Remove the Newtonsoft.Json 13.0.3 PackageReference from contentstack.model.generator.csproj now that tool internals no longer depend on it - Update ModelGenerator.cs's _templateStart, CreateLinkClass(), CreateFile(), and AddParams() to emit [JsonPropertyName] instead of [JsonProperty], and swap the Newtonsoft using statements in _templateStart for System.Text.Json / Nodes / Serialization Note: CreateEmbeddedObjectClass() and CreateModularBlockConverter() still reference Newtonsoft types (JObject/JArray) for their converter templates and are not yet migrated, so the project will not build again until that work lands.
reeshika-h
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: CreateEmbeddedObjectClass() and CreateModularBlockConverter() still reference Newtonsoft types (JObject/JArray) for their converter templates and are not yet migrated, so the project will not build again until that work lands.