refactor: migrate modular block converter template to System.Text.Json#45
Draft
OMpawar-21 wants to merge 1 commit into
Draft
refactor: migrate modular block converter template to System.Text.Json#45OMpawar-21 wants to merge 1 commit into
OMpawar-21 wants to merge 1 commit into
Conversation
OMpawar-21
commented
Jul 7, 2026
OMpawar-21
commented
- Update CreateHelperClass()'s emitted FieldExists signature from JObject to JsonObject
- Rewrite CreateModularBlockConverter()'s emitted converter from Newtonsoft's ReadJson()/WriteJson()/serializer.Populate() to STJ's Read()/Write(), using a parse-then-deserialize-and-replace pattern that restores the BlockType discriminator after re-deserializing the concrete block type
- Update CreateHelperClass()'s emitted FieldExists signature from JObject to JsonObject - Rewrite CreateModularBlockConverter()'s emitted converter from Newtonsoft's ReadJson()/WriteJson()/serializer.Populate() to STJ's Read()/Write(), using a parse-then-deserialize-and-replace pattern that restores the BlockType discriminator after re-deserializing the concrete block type
reeshika-h
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.