Skip to content

[VB797] [LowercaseLocale] Added option in addTags to disable lowercasing of locale #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshithad0703 merged 3 commits into from
Feb 2, 2026
Merged

[VB797] [LowercaseLocale] Added option in addTags to disable lowercasing of locale #245

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1044625
fix: option to disable lowercase locale
csAyushDubey Jan 28, 2026
62ee914
test: added tests for addEditableTags options arg
csAyushDubey Jan 29, 2026
9b0b66a
Merge branch 'development' into bug/VB-797-lowercase-locale
nadeem-cs Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/entry-editable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,14 @@
metaKey: string
}

export function addTags(entry: EntryModel, contentTypeUid: string, tagsAsObject: boolean, locale: string = 'en-us'): void {
export function addTags(entry: EntryModel, contentTypeUid: string, tagsAsObject: boolean, locale: string = 'en-us', options?: {
Comment thread
nadeem-cs marked this conversation as resolved.
useLowerCaseLocale?: boolean
}): void {
const { useLowerCaseLocale = true } = options || {};

Check warning on line 12 in src/entry-editable.ts

View workflow job for this annotation

GitHub Actions / Coverage annotations (🧪 jest-coverage-report-action)

🌿 Branch is not covered 

Warning! Not covered branch
if (entry) {
// handle case senstivity for contentTypeUid and locale
contentTypeUid = contentTypeUid.toLowerCase();
locale = locale.toLowerCase();
locale = useLowerCaseLocale ? locale.toLowerCase() : locale;

Check warning on line 16 in src/entry-editable.ts

View workflow job for this annotation

GitHub Actions / Coverage annotations (🧪 jest-coverage-report-action)

🌿 Branch is not covered 

Warning! Not covered branch

const appliedVariants = entry._applied_variants || entry?.system?.applied_variants || null;
entry.$ = getTag(entry, `${contentTypeUid}.${entry.uid}.${locale}`, tagsAsObject, locale, { _applied_variants: appliedVariants, shouldApplyVariant: !!appliedVariants, metaKey: '' })
Expand Down
Loading