release: promote develop_v4 to stage_v4#619
Merged
Merged
Conversation
…d patch npm audit vulnerabilities
fix(VP-2254): keep cursor visible over RTE links in Visual Builder
…own toolbar With overlayPropagation enabled, clicks landing on the visual builder's own UI (field toolbar, overlays) were resolved through document.elementsFromPoint and could hit a data-cslp element rendered underneath. A click on the edit (pencil) button then also counted as a canvas click on the overlapped field, sending a focus event for the wrong entry and breaking the edit modal's apply flow. Skip the elementsFromPoint fallback whenever the click target sits inside .visual-builder__container: the fallback exists to pierce the website's own overlapping elements, never the SDK's chrome.
…pagation-toolbar-pierce
…dition Run the closest() check only when the overlayPropagation fallback is enabled and no field matched, so hover events skip the extra DOM traversal in the common case.
…lbar-pierce fix(visual-builder): keep overlayPropagation from piercing the SDK's own toolbar
…llowing the click
fix(VB-1820): navigate on alt+click of in-iframe links instead of swallowing the click
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
develop_v4 → stage_v4
Promotes the latest fixes from
develop_v4tostage_v4ahead of the next release.What's changed
Fixes
overlayPropagationflag no longer lets clicks pierce through the SDK's own toolbar; the own-UI guard is folded into the fallback condition.Tests
mouseClick), element data resolution (getCsDataOfElement), and the start-editing button.