fix: make component drawer table rows inert, move selection to the name control - #66
Open
marekdano wants to merge 1 commit into
Open
fix: make component drawer table rows inert, move selection to the name control#66marekdano wants to merge 1 commit into
marekdano wants to merge 1 commit into
Conversation
…me control Signed-off-by: Marek Dano <mk.dano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59
Summary
onClick/onKeyDown/tabIndex/cursor-pointerand the row-level focus ring fromToolsTable,ResourcesTable, andPromptDefinitionTable— rows arenow inert, matching
ServersTable.onSelect*, underlines on hover, and is keyboard-activatable natively, removing the needfor the 20
stopPropagation()calls that only existed to shield row controls from the row's own click handler.text-muted-foreground→text-foreground) instead of only theicon button reacting.
Test plan
ToolsTable,ResourcesTable,PromptDefinitionTable, plus one each inToolDetailsPanelandPromptDetailsPanel)that asserted row-click/row-keyboard/
cursor-pointerbehavior at the new name button.npx vitest run— 3054 passed, 1 skipped.npx playwright test e2e/tools.spec.ts e2e/resources.spec.ts e2e/prompts.spec.ts— 67 passed, no changes needed (specs drive selection via the overflowmenu, not row clicks).
tsc --noEmitandeslintclean on changed files.