fix(gemini): forward requestOptions.headers to GoogleGenAI httpOptions#12009
Open
serhiizghama wants to merge 1 commit intocontinuedev:mainfrom
Open
fix(gemini): forward requestOptions.headers to GoogleGenAI httpOptions#12009serhiizghama wants to merge 1 commit intocontinuedev:mainfrom
serhiizghama wants to merge 1 commit intocontinuedev:mainfrom
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
GeminiApiconstructor initializesGoogleGenAIwithout forwardingrequestOptions.headersto the SDK. Custom headers configured viarequestOptions.headersinconfig.yaml(e.g.x-api-keyfor enterprise Gemini endpoints) are silently dropped for all chat/streaming requests, causing authentication errors like:{"error": {"code": 400, "message": "API key not valid.", "status": "INVALID_ARGUMENT"}}Root cause
In
packages/openai-adapters/src/apis/Gemini.ts, theGoogleGenAIinstance is created withouthttpOptions:Custom headers work in
embed()because it usescustomFetch(this.config.requestOptions), which does mergerequestOptions.headers. But chat goes throughthis.genAI, which never sees them.What changed
Pass
requestOptions.headerstoGoogleGenAIvia thehttpOptions.headersfield, which the@google/genaiSDK fully supports (HttpOptions.headers: Record<string, string>):How to test
Configure a Gemini model with a custom header that replaces the API key auth:
With this fix, the header is forwarded and chat requests succeed instead of returning
401/400.Fixes #12008
Summary by cubic
Forward custom headers from
requestOptions.headersto@google/genaiviahttpOptions.headers. This makes Gemini chat and streaming requests include enterprise auth (e.g.,x-api-key) and fixes invalid API key errors.requestOptions.headerswhen constructingGoogleGenAI(insidewithNativeFetch).Written for commit 3cf3798. Summary will update on new commits.