fix(cli): abort headless streams on SIGINT - #13070
Open
d3f4w2 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the headless CLI cancellation gap reported in #12701.
The active provider stream now receives an abort signal synchronously when the process receives
SIGINT. This prevents delayed provider chunks from reaching tool-call handling while the process-level shutdown handler is still awaiting cleanup. The temporary signal listener is removed after both successful and failed requests.The TUI signal path is unchanged.
Closes #12701.
AI assistance disclosure: I used an AI coding assistant to help trace the cancellation flow and prepare the patch. I reviewed the changes and ran the validation below.
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
Not applicable; this fixes headless process cancellation behavior.
Tests
npm test -- --run src/util/withSigintAbort.test.ts src/stream/streamChatResponse.test.ts— 10 passed, 6 skippednpm run buildgit diff --check