fix: FP with the CONVERT keyword while exporting data#51
Conversation
Commented out the test due to plugin configuration issues.
EsadCetiner
left a comment
There was a problem hiding this comment.
As someone who doesn't use PHPMyAdmin, a lot of the rules look pretty repetitive here, particularly the ones that handle inputs for SQL queries.
The rules also need to be better organized too, right now everything is either in new or old URL format. I think the plugin is too big to only have 2-3 sections for rules.
|
Well, i don't see a need for some organization. |
|
Can you be more specific? Maybe i'm misunderstanding you. |
|
@azurit Organizing the rules better would mean that it's easier to read for someone who's not familiar with the plugin. The other plugins for instance organize the rule exclusion based on functionality, for instance there could be one section for relating to DB imports/exports, another for settings, another for interacting with the database, etc. I'm not an expert on this particular plugin, but I just see some things that could be a bit better. |
Also updating copyright.