Skip to content

fix: FP with the CONVERT keyword while exporting data#51

Merged
azurit merged 8 commits into
coreruleset:masterfrom
azurit:FPexport
Jul 3, 2026
Merged

fix: FP with the CONVERT keyword while exporting data#51
azurit merged 8 commits into
coreruleset:masterfrom
azurit:FPexport

Conversation

@azurit

@azurit azurit commented Jul 2, 2026

Copy link
Copy Markdown
Member

Also updating copyright.

@azurit azurit requested a review from EsadCetiner July 2, 2026 18:17

@EsadCetiner EsadCetiner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone who doesn't use PHPMyAdmin, a lot of the rules look pretty repetitive here, particularly the ones that handle inputs for SQL queries.

The rules also need to be better organized too, right now everything is either in new or old URL format. I think the plugin is too big to only have 2-3 sections for rules.

@azurit

azurit commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

Well, i don't see a need for some organization.

@azurit

azurit commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

Can you be more specific? Maybe i'm misunderstanding you.

@azurit azurit merged commit fcc94fe into coreruleset:master Jul 3, 2026
3 checks passed
@EsadCetiner

Copy link
Copy Markdown
Member

@azurit Organizing the rules better would mean that it's easier to read for someone who's not familiar with the plugin. The other plugins for instance organize the rule exclusion based on functionality, for instance there could be one section for relating to DB imports/exports, another for settings, another for interacting with the database, etc.

I'm not an expert on this particular plugin, but I just see some things that could be a bit better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants