Add CrashOnPanic middleware + wrap distributor push routes#7709
Open
justinjung04 wants to merge 2 commits into
Open
Add CrashOnPanic middleware + wrap distributor push routes#7709justinjung04 wants to merge 2 commits into
justinjung04 wants to merge 2 commits into
Conversation
Signed-off-by: Justin Jung <jungjust@amazon.com>
justinjung04
force-pushed
the
distributor-panic
branch
from
July 20, 2026 21:20
6a02495 to
94d7dca
Compare
justinjung04
marked this pull request as ready for review
July 20, 2026 21:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds a
CrashOnPanicHTTP middleware that terminates the distributor process when a panic occurs during request handling, instead of letting Go's defaultnet/httprecovery keep the process running in a corrupted state.This is motivated by an incident where a distributor panicked with
growslice: len out of rangeduring protobuf unmarshal of a corruptremote_writepayload. Thenet/httpserver caught the panic and kept the process alive, but the distributor entered a bad state — returningPROTOCOL_ERRORon all gRPC health checks to ingesters. Manually deleting the pod was required to recover.Since distributors are stateless, the correct behavior is to crash immediately and let Kubernetes restart the pod with clean state.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags