Improve sentence structures by removing colons#9217
Merged
Conversation
…wing expression:". Usually, a colon concludes a complete sentence and is followed by some isolated expression or another complete sentence. In these cases, we have one long sentence with subclauses.
jwakely
approved these changes
Jul 20, 2026
jensmaurer
approved these changes
Jul 20, 2026
A colon usually ends a complete sentence and is followed either by an isolated expression or another sentence. Here, by contrast, we have a complex object, which should not be seperated like that. Additionally, the presentation seems to work better as a long sentence with the expressions appearing in codeblocks, instead of as an itemization. Morever, the quantification should say "expressions ... for _all_ <index>", not "for each", since it is the collection of all expressions that forms the argument of the "logical and". (This is opposed to, say, making a separate statement about each element of the collection.)
Contributor
Author
|
I made a further change to a) include another case I had missed, and b) to replace the itemizations with codeblocks: 
I think that works a lot better and also avoids the need for awkward manual linebreaks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are dealing with long, complete sentences, where it does not seem appropriate to separate parts with colons.
I suggest various rewrites that incorporate the complex object of the sentence in a more natural way.
In [ranges], I would also like to change "for each" to "for all" in the description of the argument of the "logical AND".